-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Make plotly.py's validator compatible with plotly.js 1.57.0 which now allows domain referenced axis references #2838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks great! are you able to avoid the whitespace changes here at all? Would be nice to include just the changes you made to the code. 💃 |
|
Can you ensure you're using the same version of |
ah I guess we don't pin it. I have |
black, version 20.8b1 |
All it "requires" (ROFL) is a little |
well, it's helpful to get a warning when a newer version of pandas is incompatible with our stuff... but yeah let's pin black to |
Ah, I see it's nice that it shows that automatically. What if releases are pinned but master isn't? Then the warnings happen in master but the releases always work. |
Unfortunately running |
OK, can you please undo the whitespace changes and merge then? |
This just involves adding ' domain' to
EnumeratedValidator.build_regex_replacement