Skip to content

Make plotly.py's validator compatible with plotly.js 1.57.0 which now allows domain referenced axis references #2838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 16, 2020

Conversation

nicholas-esterer
Copy link
Contributor

This just involves adding ' domain' to EnumeratedValidator.build_regex_replacement

@nicholas-esterer nicholas-esterer changed the title Make pltoly.py's validator compatible with plotly.js 1.57.0 which now allows domain referenced axis references Make plotly.py's validator compatible with plotly.js 1.57.0 which now allows domain referenced axis references Oct 16, 2020
@nicolaskruchten
Copy link
Contributor

Looks great! are you able to avoid the whitespace changes here at all? Would be nice to include just the changes you made to the code.

💃

@nicholas-esterer
Copy link
Contributor Author

black did that I think. There's always git diff -b ;)

@nicolaskruchten
Copy link
Contributor

Can you ensure you're using the same version of black as is in the repo?

@nicolaskruchten
Copy link
Contributor

ah I guess we don't pin it. I have 19.10b0, how about you?

@nicholas-esterer
Copy link
Contributor Author

black, version 20.8b1
In general, why don't we pin stuff always? It seems to break stuff often when pip repos are upgraded.

@nicholas-esterer
Copy link
Contributor Author

All it "requires" (ROFL) is a little pip freeze > requirements.txt

@nicolaskruchten
Copy link
Contributor

well, it's helpful to get a warning when a newer version of pandas is incompatible with our stuff... but yeah let's pin black to 19.10b0 for now. Can you do that in this PR and rerun it on your changes?

@nicholas-esterer
Copy link
Contributor Author

Ah, I see it's nice that it shows that automatically. What if releases are pinned but master isn't? Then the warnings happen in master but the releases always work.
Anyhow I can try pinning black 👍

@nicholas-esterer
Copy link
Contributor Author

Unfortunately running black version 19.10b0 doesn't change the file packages/python/plotly/_plotly_utils/basevalidators.py, but I pinned it in optional-requirements.txt.

@nicolaskruchten
Copy link
Contributor

OK, can you please undo the whitespace changes and merge then?

@nicholas-esterer nicholas-esterer merged commit 54efc64 into master Oct 16, 2020
@nicholas-esterer nicholas-esterer deleted the plotlyjs-v1.57.0-compat branch October 16, 2020 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants